refactor: updated elevenLabs API module and `remove button` UX #6781

Abhijay007 · 2026-01-28T18:14:08Z

ref : #6557 (comment), #6557 (comment)

PR Description

updated elevenLabs API module and remove UX

Type of Change

Refactor / Code quality

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Tested In Desktop UI

Screenshots/Demos (for UX changes)

Copilot

Pull request overview

Refactors the ElevenLabs API key settings UI in the desktop app by simplifying state management and removing some loading/validation UX.

Changes:

Simplifies initial key detection to a single useEffect check.
Switches save/remove flows to optimistic local state updates (no reload-based recheck).
Adjusts the UI to show a dedicated “Remove API Key” action outside edit mode and removes inline validation/error messaging.

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

lifeizhou-ap

Thank you @Abhijay007 for this improvement!

Abhijay007 · 2026-01-30T12:14:11Z

@DOsinga, could you please take a look at this as well? I believe it’s ready to be merged. I’m asking since you had initially mentioned the refactor in the other PR

Abhijay007 · 2026-02-02T18:12:36Z

Hi @DOsinga , @lifeizhou-ap I updated this PR as during the recent refactor in this PR : #6844, it broke ElevenLabs by using ApiClient wrapper instead of direct HTTP client so I reverted that and updated remove button UX, which was requested before

DOsinga · 2026-02-02T18:12:55Z

I'm sorry I refactored the entire way we do this over the weekend - the config now comes from the server, you'll have a terrible merge conflict on your hands

Abhijay007 · 2026-02-02T18:14:27Z

I'm sorry I refactored the entire way we do this over the weekend - the config now comes from the server, you'll have a terrible merge conflict on your hands

no problem I updated it , you can review it now :) @DOsinga

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

crates/goose-server/src/routes/dictation.rs:270

The ElevenLabs multipart part creation discards the underlying reqwest error (map_err(|_| ...)), which makes failures harder to diagnose; preserve the original error message (as is done in transcribe_openai) when constructing the internal ErrorResponse.

    let part = reqwest::multipart::Part::bytes(audio_bytes)
        .file_name(format!("audio.{}", extension))
        .mime_str(mime_type)
        .map_err(|_| ErrorResponse::internal("Failed to create multipart"))?;

Copilot · 2026-02-02T18:23:26Z

ui/desktop/src/components/settings/dictation/DictationSettings.tsx

-      setKeyValidationError('API key is required');
-      return;
-    }
+    if (!trimmedKey) return;


Clicking “Save” with an empty/whitespace API key currently just returns with no UI feedback, which makes the button appear broken; disable the Save button until a non-empty key is entered or reintroduce a small inline validation message.

Suggested change

if (!trimmedKey) return;

if (!trimmedKey) {

window.alert('Please enter a non-empty API key before saving.');

return;

}

Copilot · 2026-02-02T18:23:26Z

crates/goose-server/src/routes/dictation.rs

+    let http_client = reqwest::Client::builder()
+        .timeout(REQUEST_TIMEOUT)
+        .build()
+        .map_err(|e| ErrorResponse::internal(format!("Failed to create HTTP client: {}", e)))?;


This creates a new reqwest::Client for every ElevenLabs transcription request, which prevents connection pooling and adds unnecessary overhead; consider reusing a shared client (e.g., stored in AppState or a static Lazy client) configured with the same timeout.

DOsinga

before we continue, can you make sure you merge in main? this looks different and sorry again for changing everything

DOsinga · 2026-02-02T18:30:20Z

crates/goose-server/src/routes/dictation.rs

    Ok(data.text)
 }

 async fn transcribe_elevenlabs(


this doesn't match main, I removed all specific transcribing, there is now just a transcribe_dictation method that takes a DictationProvider to indicate how to transcribe

umm that's strange, let me look into it, I remember rebasing

well this is in main rn:

goose/crates/goose-server/src/routes/dictation.rs

Line 260 in a9f4b2d

async fn transcribe_elevenlabs(

I am not sure if that came from some other PR: cc @DOsinga

Signed-off-by: Abhijay007 <[email protected]>

DOsinga · 2026-02-02T18:36:00Z

we have a merge queue now after some incidents, so it might take a tad longer to see the latest in main

Abhijay007 · 2026-02-02T18:37:32Z

we have a merge queue now after some incidents, so it might take a tad longer to see the latest in main

Oh, okay so should we wait ? Like when I am taking pull, it is not reflecting for me

DOsinga · 2026-02-02T18:40:39Z

hmm, what does your routers/dictation.rs ends on? mine has:

pub fn routes(state: Arc) -> Router {
Router::new()
.route("/dictation/transcribe", post(transcribe_dictation))
.route("/dictation/config", get(get_dictation_config))
.with_state(state)
}

Abhijay007 · 2026-02-02T18:42:30Z

hmm, what does your routers/dictation.rs ends on? mine has:

pub fn routes(state: Arc) -> Router { Router::new() .route("/dictation/transcribe", post(transcribe_dictation)) .route("/dictation/config", get(get_dictation_config)) .with_state(state) }

same for me

DOsinga · 2026-02-02T19:11:30Z

oh, I am sorry, yes, that is main. I do have another refactor though that changes even more coming up if you can wait on that? that generalizes things even more

Abhijay007 · 2026-02-02T19:12:39Z

oh, I am sorry, yes, that is main. I do have another refactor though that changes even more coming up if you can wait on that? that generalizes things even more

Yea sure will update the PR once those changes get merged

DOsinga · 2026-02-03T12:10:20Z

merged

Abhijay007 · 2026-02-03T12:16:20Z

Sure will update it today

Abhijay007 requested review from DOsinga, Copilot and lifeizhou-ap January 28, 2026 18:14

Copilot started reviewing on behalf of Abhijay007 January 28, 2026 18:14 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Abhijay007 changed the title ~~refactor: updated elevenLabs API module and remove UX~~ refactor: updated elevenLabs API module and remove button UX Jan 28, 2026

lifeizhou-ap approved these changes Jan 29, 2026

View reviewed changes

Abhijay007 force-pushed the refactor/elevenLabsModule branch from b6ae3ab to aa0da6c Compare February 2, 2026 18:10

Abhijay007 requested a review from lifeizhou-ap February 2, 2026 18:10

Copilot AI review requested due to automatic review settings February 2, 2026 18:15

Copilot started reviewing on behalf of Abhijay007 February 2, 2026 18:18 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

DOsinga reviewed Feb 2, 2026

View reviewed changes

Abhijay007 added 3 commits February 2, 2026 18:32

fix: reverted elevenlabs direct HTTP client approach

f27cb24

Signed-off-by: Abhijay007 <[email protected]>

refactor: updated remove button ux

3b94820

Signed-off-by: Abhijay007 <[email protected]>

refactor: updated lint

12a3128

Signed-off-by: Abhijay007 <[email protected]>

Abhijay007 force-pushed the refactor/elevenLabsModule branch from 5e30bda to 12a3128 Compare February 2, 2026 18:32

-    if (!trimmedKey) return;
+    if (!trimmedKey) {
+      window.alert('Please enter a non-empty API key before saving.');
+      return;
+    }

refactor: updated elevenLabs API module and remove button UX #6781

Are you sure you want to change the base?

refactor: updated elevenLabs API module and remove button UX #6781

Conversation

Abhijay007 commented Jan 28, 2026

PR Description

Type of Change

AI Assistance

Testing

Screenshots/Demos (for UX changes)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lifeizhou-ap left a comment

Choose a reason for hiding this comment

Uh oh!

Abhijay007 commented Jan 30, 2026

Uh oh!

Abhijay007 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga commented Feb 2, 2026

Uh oh!

Abhijay007 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

DOsinga Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Abhijay007 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Abhijay007 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

DOsinga commented Feb 2, 2026

Uh oh!

Abhijay007 commented Feb 2, 2026

Uh oh!

DOsinga commented Feb 2, 2026

Uh oh!

Abhijay007 commented Feb 2, 2026

Uh oh!

DOsinga commented Feb 2, 2026

Uh oh!

Abhijay007 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga commented Feb 3, 2026

Uh oh!

Abhijay007 commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: updated elevenLabs API module and `remove button` UX #6781

refactor: updated elevenLabs API module and `remove button` UX #6781

Abhijay007 commented Feb 2, 2026 •

edited

Loading

Abhijay007 commented Feb 2, 2026 •

edited

Loading

Abhijay007 commented Feb 2, 2026 •

edited

Loading